perf: opcache-friendly compiled config for routes.xml#40690
Open
lbajsarowicz wants to merge 2 commits intomagento:2.4-developfrom
Open
perf: opcache-friendly compiled config for routes.xml#40690lbajsarowicz wants to merge 2 commits intomagento:2.4-developfrom
lbajsarowicz wants to merge 2 commits intomagento:2.4-developfrom
Conversation
…configs XML configurations that are immutable after deployment (events.xml, etc.) are currently stored in the cache backend as JSON strings and decoded via json_decode() on every request. This adds an optional compile-on-first-access mechanism that writes config arrays to PHP files in generated/metadata/, which PHP opcache can cache as bytecode — eliminating both the cache backend round-trip and the JSON decode overhead. The implementation modifies Config\Data and Config\Data\Scoped base classes to accept an optional ConfigWriterInterface dependency. When injected: - First checks for a compiled PHP file via include() (opcache-friendly) - Falls back to existing cache/reader behavior on miss - Writes the compiled PHP file atomically (temp + rename) for next request - Properly invalidates compiled files on reset()/cache clean Event configuration (events.xml) is enabled as the first consumer via DI. This pattern can be extended to other immutable configs (routes, webapi, acl) in follow-up PRs. Backward compatible: no behavior change when ConfigWriterInterface is not injected (default). Compiled files live alongside existing DI compiled config in generated/metadata/ and follow the same lifecycle.
|
Hi @lbajsarowicz. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Contributor
Author
|
@magento run all tests |
- Extract anonymous test doubles into named classes to fix PHPMD UnusedLocalVariable false positives in anonymous class methods - Add phpcs:disable for useless override warning in Event\Config\Data (constructor provides default cacheId, matching existing pattern in Catalog\Attribute\Config\Data) - All PHPCS errors/warnings and PHPMD violations resolved
Contributor
Author
|
@magento run all tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Magento\Framework\App\Route\ConfigPerformance Impact
Exact numbers with Blackfire and PHP SPX profiling will be provided in a follow-up comment.
Dependencies
Depends on #40689 (base class changes for compiled config support).
⭐ Support my work
Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.
Learn more at https://github.com/sponsors/lbajsarowicz