adding the sku in error message about sku with no associated stock#3356
Open
iphigenie wants to merge 6 commits intomagento:developfrom
Open
adding the sku in error message about sku with no associated stock#3356iphigenie wants to merge 6 commits intomagento:developfrom
iphigenie wants to merge 6 commits intomagento:developfrom
Conversation
Author
|
note that I have the same for the versions pushed with 2.4.4 and 2.4.3 releases but I haven't got a clue how to fork and pull request for a particular branch - and it'd only matter if there's a 2.4.5 coming |
Author
|
Hi - I'd happily work at improving error messages so they are more useful in log but how do I get people to review and push? these are cosmetic QoL and should be super easy wins |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
The inventory module raises errors and exceptions that say
"The requested sku is not assigned to given stock."
As third party extensions and possibly some internal functions call these methods without isolating the exceptions (it should be possible to have products not associated to stock still shown on the site, just not buyable) one can sometimes find dozens and dozens of such error messages without any clarity whether it is one product causing them all or many different ones.
It would be more helpful is the SKU was added to the message.
This changes 2 i18n files and 4 model files to add the %1 variable so the message will contain the sku
Fixed Issues (if relevant)
Manual testing scenarios (*)
This is just a quality of life cosmetic change, making errors more informative.
Questions or comments
Contribution checklist (*)