fix: use lstat instead of stat to detect symlinks in getFileMode#1200
Open
FuturizeRush wants to merge 1 commit intoanthropics:mainfrom
Open
fix: use lstat instead of stat to detect symlinks in getFileMode#1200FuturizeRush wants to merge 1 commit intoanthropics:mainfrom
FuturizeRush wants to merge 1 commit intoanthropics:mainfrom
Conversation
Node.js stat() follows symlinks and reports the target's type, so fileStat.isSymbolicLink() always returns false. This causes symlinks to be committed with mode 100644 (regular file) instead of 120000 (symbolic link), corrupting the file type in the Git tree. lstat() does not follow symlinks, so isSymbolicLink() correctly returns true for symlink entries.
AlvaroRuizGomez
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
stat()withlstat()ingetFileMode()so symlinks are correctly detected and committed with Git mode120000.Bug
src/mcp/github-file-ops-server.ts:170usesstat(), which follows symlinks and reports the target file's type.isSymbolicLink()on astat()result always returnsfalse.Symlinks are committed as regular files (mode
100644) instead of symlinks (mode120000).Fix
stat()→lstat().lstat()does not follow symlinks, soisSymbolicLink()correctly returnstrue.Verified with Node.js
Test plan
tsc --noEmitpassesstat()returns false,lstat()returns truelstat()behaves identically tostat()for non-symlinks)