fix: correct async docstring example in BetaAsyncAbstractMemoryTool#1334
Open
muhammadrashid4587 wants to merge 1 commit intoanthropics:mainfrom
Open
fix: correct async docstring example in BetaAsyncAbstractMemoryTool#1334muhammadrashid4587 wants to merge 1 commit intoanthropics:mainfrom
muhammadrashid4587 wants to merge 1 commit intoanthropics:mainfrom
Conversation
The docstring example was copy-pasted from the sync class without updating for async usage: - Use BetaAsyncAbstractMemoryTool instead of BetaAbstractMemoryTool - Use async def for method implementations - Use AsyncAnthropic instead of Anthropic - Use await for the client call Fixes anthropics#1290
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the copy-pasted sync docstring example in
BetaAsyncAbstractMemoryToolthat would causeTypeErrorif followed verbatim:BetaAbstractMemoryTool→BetaAsyncAbstractMemoryTooldef view/create→async def view/createAnthropic()→AsyncAnthropic()client.beta.messages.run_tools(...)→await client.beta.messages.run_tools(...)Fixes #1290
Test plan