Follow-up from PR #9618
This issue was created as a follow-up to a review comment in PR #9618 by @EvilOlaf that was deemed out of scope for that PR.
File: patch/kernel/archive/rockchip64-7.0/rk3528-14-arm64-dts-rockchip-nanopi-zero2-fix-ethernet-phy-reset.patch
Concern: The patch uses the plural form snps,reset-gpios as the property name in the &gmac1 device-tree node, while all other Ethernet controllers in the rockchip64-7.0 patch set use the singular form snps,reset-gpio. The plural form may not be recognized by the DT binding parser.
Proposed fix:
- snps,reset-gpios = <&gpio4 RK_PC2 GPIO_ACTIVE_LOW>;
+ snps,reset-gpio = <&gpio4 RK_PC2 GPIO_ACTIVE_LOW>;
snps,reset-delays-us = <0 20000 100000>;
Please verify which form is correct per the upstream stmmac/GMAC DT binding documentation and update the patch accordingly.
References:
/cc @rubycomm @EvilOlaf
Follow-up from PR #9618
This issue was created as a follow-up to a review comment in PR #9618 by @EvilOlaf that was deemed out of scope for that PR.
File:
patch/kernel/archive/rockchip64-7.0/rk3528-14-arm64-dts-rockchip-nanopi-zero2-fix-ethernet-phy-reset.patchConcern: The patch uses the plural form
snps,reset-gpiosas the property name in the&gmac1device-tree node, while all other Ethernet controllers in the rockchip64-7.0 patch set use the singular formsnps,reset-gpio. The plural form may not be recognized by the DT binding parser.Proposed fix:
Please verify which form is correct per the upstream stmmac/GMAC DT binding documentation and update the patch accordingly.
References:
edgeto 7.0-rc6 #9618edgeto 7.0-rc6 #9618 (comment)/cc @rubycomm @EvilOlaf